Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32U5 new family introduction #15022

Merged
merged 13 commits into from
Sep 10, 2021
Merged

STM32U5 new family introduction #15022

merged 13 commits into from
Sep 10, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

This is the introduction of a new STM32 family:
https://www.st.com/en/microcontrollers-microprocessors/stm32u5-series.html

2 targets are supported:

PS: To do (in further PR):

  • B_U585I_IOT02A: Wifi support
  • B_U585I_IOT02A: BLE support
  • B_U585I_IOT02A: HW crypto support
  • USB device support

@ARMmbed/team-st-mcd
@jmg-st
@MarceloSalazar

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Tests done:

  • GCC / ARM / IAR

  • CLI1 and CLI2

  • FPGA tests OK

    [] No Tests required for this change (E.g docs only update)
    [x] Covered by existing mbed-os tests (Greentea or Unittest)
    [] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 25, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 25, 2021 08:30
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2021

New files do not have SPDX identifier (see license check failures).

@mergify
Copy link

mergify bot commented Aug 25, 2021

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Hey, I reacted but my real name is @Mergifyio

@0xc0170 0xc0170 mentioned this pull request Aug 25, 2021
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2021

I am reporting Mergify comments, I saw this in another 3 PRs as well today.

@mergify
Copy link

mergify bot commented Aug 25, 2021

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Hey, I reacted but my real name is @Mergifyio

@jeromecoutant
Copy link
Collaborator Author

New files do not have SPDX identifier (see license check failures).

Yes, files from https://github.com/STMicroelectronics/STM32CubeU5/ doesn't have.
Like all other STM32 families...

@mergify

This comment has been minimized.

Sign in to view
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2021

Correct, how come old Travis check did not fail? Fixing upstream would take some time so the only way forward is to ignore the license check (after reviewing that only SPDX is missing).

LMESTM
LMESTM approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments, but approving already !

targets/TARGET_STM/TARGET_STM32U5/PeripheralNames.h Outdated Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/analogin_device.c Outdated Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/analogout_device.c Outdated Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/can_device.h Outdated Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/TARGET_STM32U575xG/system_clock.c Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/TARGET_STM32U575xI/system_clock.c Show resolved Hide resolved
targets/TARGET_STM/TARGET_STM32U5/TARGET_STM32U585xI/system_clock.c Show resolved Hide resolved
@jeromecoutant
Copy link
Collaborator Author

jeromecoutant commented Aug 26, 2021 •
edited
Loading

Correct, how come old Travis check did not fail? Fixing upstream would take some time so the only way forward is to ignore the license check (after reviewing that only SPDX is missing).

You could add a filter in your license script to remove */STM32Cube_FW/* files

@jeromecoutant jeromecoutant force-pushed the PR_STM32U5 branch 2 times, most recently from cff2e25 to f600abd Compare August 27, 2021 16:11
@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 31, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2021

Basic Checks / license-check (pull_request) is broken on master. I'll create a new issue now and reproduce it locally

@jeromecoutant jeromecoutant mentioned this pull request Aug 31, 2021
Closed
@ciarmcom ciarmcom removed the stale Stale Pull Request label Aug 31, 2021
@mergify
Copy link

mergify bot commented Sep 2, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jeromecoutant jeromecoutant force-pushed the PR_STM32U5 branch 2 times, most recently from a0d5887 to 5f21424 Compare September 3, 2021 07:34
@mbed-ci
Copy link

mbed-ci commented Sep 10, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot dismissed 0xc0170’s stale review September 10, 2021 09:18

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f96b930 into ARMmbed:master Sep 10, 2021
@mergify mergify bot removed the ready for merge label Sep 10, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
@jeromecoutant jeromecoutant deleted the PR_STM32U5 branch September 22, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@LMESTM LMESTM LMESTM approved these changes

Assignees
No one assigned
Labels
component: tools devices: st release-version: 6.15.0 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @LMESTM @erwango @mbedmain