add RTC using HSE to target STM32F1 #15034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKarel
changed the title
ciarmcom
added
the
release-type: patch
|
@LukasKarel, thank you for your changes. |
targets/TARGET_STM/mbed_overrides.c
Outdated
| @@ -292,7 +292,11 @@ void mbed_sdk_init() | |||
| #if (MBED_CONF_TARGET_RTC_CLOCK_SOURCE == USE_RTC_CLK_HSE) | |||
| RCC_PeriphCLKInitTypeDef PeriphClkInitStruct = {0}; | |||
| PeriphClkInitStruct.PeriphClockSelection = RCC_PERIPHCLK_RTC; | |||
| #if (!TARGET_STM32F1) | |||
There was a problem hiding this comment.
What about:
#if defined(RCC_RTCCLKSOURCE_HSE_DIVX)
There was a problem hiding this comment.
What about:
#if defined(RCC_RTCCLKSOURCE_HSE_DIVX)
This should work as well. I will change it asap.
LukasKarel
force-pushed
the
feature/stm32f1_rtcHSE
branch
from
bde271b
to
92991d8
Compare
LukasKarel
requested review from
jeromecoutant
and removed request for
a team
jeromecoutant
approved these changes
Sep 1, 2021
|
Please rebase to the latest master to get github workflow update to fix basic checks |
LukasKarel
force-pushed
the
feature/stm32f1_rtcHSE
branch
from
92991d8
to
e4f0281
Compare
|
@0xc0170 done |
0xc0170
approved these changes
Sep 1, 2021
|
Ci started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.15.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The clock tree of the STM32F1 allows to use RTC with HSE but this was not possible to configure with the mbed configuration system. This is now added accordingly.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers