-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mbed-os-env docker digest retrieval #15052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Sep 6, 2021
@saheerb, thank you for your changes. |
0xc0170
previously approved these changes
Sep 6, 2021
Adapt changes in skopeo command line to inspect docker image. Use tagged skopeo docker image to avoid breakage in future.
mergify
bot
dismissed
0xc0170’s stale review
September 6, 2021 10:01
Pull request has been modified.
@saheerb, thank you for your changes. |
0xc0170
approved these changes
Sep 6, 2021
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.15.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt changes in skopeo command line to inspect docker image.
Use tagged skopeo docker image to avoid breakage in future.
Summary of changes
mbed-os-env docker images bundles environment to quick start mbed-os development. GithHub Actions in this repository builds and publishes the docker images to GitHub Container Registries (GHCR). In the GitHub Action workflow, skopeo docker image manages the docker images in GHCR. Latest version of skopeo has changed the way some commands are executed. As the GitHub Actions were using latest skopeo images, currently these GitHub Actions are failing. This PR adapted the skopeo command line changes and also attached the skopeo usage to a particular tag version.
This PR also tags the images generated by master branch to 'latest'.
Impact of changes
No
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers