Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mbed-os-env docker digest retrieval #15052

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Conversation

saheerb
Copy link
Contributor

@saheerb saheerb commented Sep 6, 2021

Adapt changes in skopeo command line to inspect docker image.
Use tagged skopeo docker image to avoid breakage in future.

Summary of changes

mbed-os-env docker images bundles environment to quick start mbed-os development. GithHub Actions in this repository builds and publishes the docker images to GitHub Container Registries (GHCR). In the GitHub Action workflow, skopeo docker image manages the docker images in GHCR. Latest version of skopeo has changed the way some commands are executed. As the GitHub Actions were using latest skopeo images, currently these GitHub Actions are failing. This PR adapted the skopeo command line changes and also attached the skopeo usage to a particular tag version.

This PR also tags the images generated by master branch to 'latest'.

Impact of changes

No

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 6, 2021
@ciarmcom ciarmcom requested a review from a team September 6, 2021 08:30
@ciarmcom
Copy link
Member

ciarmcom commented Sep 6, 2021

@saheerb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Sep 6, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Sep 6, 2021
Adapt changes in skopeo command line to inspect docker image.
Use tagged skopeo docker image to avoid breakage in future.
@ciarmcom
Copy link
Member

ciarmcom commented Sep 6, 2021

@saheerb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 6, 2021 10:30
@saheerb saheerb marked this pull request as ready for review September 6, 2021 11:45
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2021

CI started

@mergify mergify bot added the needs: CI label Sep 6, 2021
@mbed-ci
Copy link

mbed-ci commented Sep 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 63583b0 into ARMmbed:master Sep 6, 2021
@mergify mergify bot removed the ready for merge label Sep 6, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants