-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTLSSocket - destruction while handshaking lead to error #15111
Conversation
79def65
to
70e506a
Compare
@LukasKarel, thank you for your changes. |
813175c
to
a227046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add please information to the commit message (what is the issue about and how it fixes it).
Does this need also unittest addition?
… destructed. Fixed by removing timeout event from event queue on close/destruction.
a227046
to
16afca3
Compare
Pull request has been modified.
I am not sure how this should be tested correctly, because a server is needed which does not respond to a DTLS handshake request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but I would like to have connectivity team reviewed
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
When a DTLSSocket is deleted (destructor was called) while the handshake procedure is ongoing, a event is triggered after the timeout. This should not happen as the object is not valid anymore.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Reviewers