Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSPIF: Add missing mbed namespace prefix to header file #15145

Merged

Conversation

Uruloke
Copy link
Contributor

@Uruloke Uruloke commented Oct 19, 2021

Summary of changes

If compiling mbed-os with the directive MBED_NO_GLOBAL_USING_DIRECTIVE and including the QSPIF component the compiler will complain about missing/incomplete types bd_addr_t and bd_size_t. These types are defined in BlockDevice.h in the mbed namespace but the QSPIFBlockDevice.h does not prefix the types with mbed::.

This pull request adds the mbed namespace prefix to two instances where it seems to have been forgotten.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 19, 2021
@ciarmcom ciarmcom requested a review from a team October 19, 2021 13:30
@ciarmcom
Copy link
Member

@Uruloke, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit aac66fc into ARMmbed:master Oct 20, 2021
@mergify mergify bot removed the ready for merge label Oct 20, 2021
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants