-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mstd::span rename index_type to size_type according to spec #15176
Conversation
@marcemmers, thank you for your changes. |
@marcemmers Maybe the previous alias can kept to avoid breaking existing applications. |
That's possible of course. Would you prefer it if I made the index type deprecated then? Like:
|
@marcemmers let's do nonbreaking fix |
8fbfb28
to
0fb88f8
Compare
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Renames the size type in mstd::span from index_type to size_type according to the spec, see https://en.cppreference.com/w/cpp/container/span member types. Ran into this issue when trying to implement the c++23 spanstream classes that are using the size_type from span.
Impact of changes
This is breaking for everyone that used the index_type of the span. No functional changes though.
Migration actions required
Rename all usages of
span<>::index_type
tospan<>::size_type
Documentation
None
Pull request type
Test results
Reviewers