lorawan: Fix issue in unconfirmed_retransmission behavior #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue on LoRaWANStack based on lorawan v1.0.2 specification page 24 line 25-27. The specification mentioned that that end-device shall stop retransmission when receiving ANY downlink on RX1 or RX2 window. - Removed conflicting behavior in LoRaWANStack::post_process_tx_with_reception() - Updated comment section of nb_trials at lorawan_data_structures.h
|
Below is the screenshot from Interop test engine of our DUT using a patched mbed-os. The test is configured as follow:
|
|
Thank you the contribution and sharing the tests. |
0xc0170
approved these changes
Feb 11, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
added
the
release-type: patch
0xc0170
changed the title
mbedmain
added
release-version: 6.16.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #15224
Fixed issue on LoRaWANStack based on lorawan v1.0.2 specification page 24 line 25-27. The specification mentioned that that end-device shall stop retransmission when receiving ANY downlink on RX1 or RX2 window.
Impact of changes
End-device will stop retransmission of unconfirmed uplink on receiving ANY downlink, as specified
by the specificiation.
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers