Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli2 artifact name property support for cmake targets #15297

Merged

Conversation

byq77
Copy link
Contributor

@byq77 byq77 commented Jun 15, 2022

Summary of changes

This is a small update to the mbed_generate_bin_hex CMake function that will allow to set a name of binary and hex files separately from a target name. I use CLI2 and in my projects I usually have many targets that sometimes have long names and I want the output files to be short, preferably called firmware etc. After the update it will be possible by defining the ARTIFACT_NAME target property:

set_target_properties(my_target_name PROPERTIES ARTIFACT_NAME firmware) 

Impact of changes

This change does not break anything and does not change the default behavior.

Migration actions required

No.

Documentation

Not sure if there is any.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@byq77 byq77 changed the title update to mbed_generate_bin_hex cmake function cli2 artifact name property support for cmake target Jun 15, 2022
@byq77 byq77 changed the title cli2 artifact name property support for cmake target cli2 artifact name property support for cmake targets Jun 15, 2022
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 15, 2022
@ciarmcom ciarmcom requested a review from a team June 15, 2022 16:00
@ciarmcom
Copy link
Member

@byq77, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 23, 2022

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jun 23, 2022
@mbed-ci
Copy link

mbed-ci commented Jun 23, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants