-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make STM32F412xE targets build #15299
Make STM32F412xE targets build #15299
Conversation
Trying to inherit the STM32F412xE target makes the linker fail, since __CRASH_DATA_RAM_START__ is not present. Comparing LD scripts with the STM32F412xG (which has active targets) it seems that the xE variant has missed some updates somewhere. Since the LD scripts are otherwise identical, copying the (working) ones from STM32F412xG seems to do the trick. Also added flash_data.h which was missing and needed here and there (copied from xG and updated to fit the xE flash layout).
@mikrodust-henrikp, thank you for your changes. |
2 comments before review:
|
I've added the MCU_STM32F412xE in targets.json as well. As for the crash data feature that probably should be per board, so leaving that for later. |
@jeromecoutant are you happy with the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ci started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Trying to inherit the STM32F412xE target makes the linker fail, since
CRASH_DATA_RAM_START is not present. Comparing LD scripts with the
STM32F412xG (which has active targets) it seems that the xE variant has
missed some updates somewhere. Since the LD scripts are otherwise
identical, copying the (working) ones from STM32F412xG seems to do the
trick.
Also added flash_data.h which was missing and needed here and there
(copied from xG and updated to fit the xE flash layout).
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers