Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M487: Fix mbedtls_ecp_point_cmp() call with null argument #15313

Merged
merged 1 commit into from
Aug 3, 2022
Merged

M487: Fix mbedtls_ecp_point_cmp() call with null argument #15313

merged 1 commit into from
Aug 3, 2022

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jul 26, 2022

Summary of changes

This PR tries to fix null argument passed to mbedtls_ecp_point_cmp() in M487 ECC H/W port, This issue is introduced in #15289.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
M487: Fix mbedtls_ecp_point_cmp() call with null argument
127b5aa 
Guard from null argument passed to mbedtls_ecp_point_cmp() in ECC H/W port
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 26, 2022
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 26, 2022 02:30
ccli8 added a commit to OpenNuvoton/NuMaker-mbed-AWS-IoT-CSDK-OTA-example that referenced this pull request Jul 26, 2022
@ccli8
Roll back to mbed-os 6.15.1
86f7b4b 
Mbed OS 6.16.0 includes one new issue being fixed in #15313: mbedtls_ecp_point_cmp() call with null argument in M487 ECC H/W port
ARMmbed/mbed-os#15313

Roll back to old mbed-os version to exclude the issue.
@mergify mergify bot added needs: CI and removed needs: review labels Aug 3, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 3, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit e6e5083 into ARMmbed:master Aug 3, 2022
@mergify mergify bot removed the ready for merge label Aug 3, 2022
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: connectivity component: security release-version: 6.17.0 release-version: 6.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @saheerb @mbedmain