Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drivers/emac): [mbed6] Remove incorrect RMII RX ER initialization #15358

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix(drivers/emac): [mbed6] Remove incorrect RMII RX ER initialization #15358

merged 2 commits into from
Feb 1, 2023

Conversation

akiroz
Copy link
Contributor

@akiroz akiroz commented Dec 20, 2022

Summary of changes

Fixes #15348
master based PR of #15349

Affected targets:

  • ST Nucleo MB1137: Signal not routed (Ref: DocID028599 Rev 7)
    • TARGET_NUCLEO_F207ZG
    • TARGET_NUCLEO_F429ZI
    • TARGET_NUCLEO_F439ZI
    • TARGET_NUCLEO_F746ZG
    • TARGET_NUCLEO_F756ZG
    • TARGET_NUCLEO_F767ZI
  • ST 32F746GDISCOVERY: RX_ER signal is on PB10/PI10 not PG2 (Ref: DocID027590 Rev 4)
    • TARGET_DISCO_F746NG
  • ST 32F746GDISCOVERY: RX_ER signal is on PB10/PI10 not PD5 (Ref: DS11532 Rev 7)
    • TARGET_DISCO_F769NI

Impact of changes

Migration actions required

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2022

I started CI (let's see if netsockets fail also like for 5.15, we still need to investigate what has changed).

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2022

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

jeromecoutant
jeromecoutant approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 About netsocket-tls test, what(s the status with K64F ?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2022

@0xc0170 About netsocket-tls test, what(s the status with K64F ?

Same, K64F and K66F started failing as well.

@jeromecoutant
Copy link
Collaborator

Waiting for #15365 I suppose

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2023

Waiting for #15365 I suppose

We identified the problem. It's with the internal echo server, we are currently investigating how to fix this properly (it's not simple).

@jeromecoutant
Copy link
Collaborator

Let's review #15369 ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2023

Let's review #15369 ?

It was merged. Can you @akiroz please rebase your branch?

@akiroz
Copy link
Contributor Author

akiroz commented Jan 16, 2023

@0xc0170 Rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2023

CI restarted

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Jan 16, 2023
@mbed-ci
Copy link

mbed-ci commented Jan 16, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2023

I've missed the license issues here.

@akiroz would you be able to fix the SDPX id in the files and add one license header. It should be trivial (just using license headers from drivers for example). These files were ignored long time ago, if we edit them now, they are shown in the license check (we shall fix them if we can - in this case, the fixes are simple).

@akiroz
Copy link
Contributor Author

akiroz commented Jan 24, 2023 •
edited
Loading

@0xc0170 The existing driver code seems be be under a custom permissive license from ST, should I change it to apache 2.0 but still under ST?

I'm not too familiar with the legal side of software licensing and I'm not affiliated with ST itself.

The current license is as follows:

mbed Microcontroller Library
Copyright (c) 2018, STMicroelectronics
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice,
   this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
   this list of conditions and the following disclaimer in the documentation
   and/or other materials provided with the distribution.
3. Neither the name of STMicroelectronics nor the names of its contributors
   may be used to endorse or promote products derived from this software
   without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 25, 2023

The license is BSD-3-Clause. They have it in other files so one line addition to these files is what they need.

SPDX-License-Identifier: BSD-3-Clause it is

@akiroz
Copy link
Contributor Author

akiroz commented Jan 26, 2023

SPDX identifiers added

@saheerb
Copy link
Contributor

saheerb commented Feb 1, 2023

Started CI

@saheerb saheerb mentioned this pull request Feb 1, 2023
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 1, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@saheerb saheerb merged commit 5c8e60f into ARMmbed:master Feb 1, 2023
@mergify mergify bot removed the ready for merge label Feb 1, 2023
@multiplemonomials multiplemonomials mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EMAC driver initializes an incorrect pin (PG2) on the STM32F4 -> NUCLEO_F429ZI target
5 participants
@akiroz @0xc0170 @mbed-ci @jeromecoutant @saheerb