-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix STM I2C compiler inline issue #15383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One slight improvement would be just mark it as static (it's internal helper as I understood
Let me know if you want to update it and we can test it afterwards |
if static won't prevent compiler to optimize it as inline it's fine for me, anyway I like the |
it should work the same way as the funciton below ( mbed-os/targets/TARGET_STM/i2c_api.c Line 909 in e55852c
|
sure but as it's just a var check and return, for performance and overhead I really prefer to see it as inline (as it was when created) and avoid potential "is the compiler his doing is job correctly", as this fix is needed because it don't. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
fixed #15379
Documentation
removed inline that trigger link issues on STM32WL as @0xc0170 proposal in #15379
Pull request type
Test results
Reviewers
@0xc0170 @jeromecoutant