Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change storage-class of secret_buf to static #15405

Merged
merged 1 commit into from
May 5, 2023
Merged

Change storage-class of secret_buf to static #15405

merged 1 commit into from
May 5, 2023

Conversation

szsam
Copy link
Contributor

@szsam szsam commented Apr 19, 2023

Summary of changes

Change storage-class of secret_buf to static.
Storing the address of a local variable (secret_buf) in non-local memory (prf_ptr->secret) can cause a dangling pointer bug if the address is used after the function returns.

mbed-os/connectivity/nanostack/sal-stack-nanostack/source/Security/TLS/tls_lib.c

Line 2122 in 1b77cda

prf_ptr->secret = secret_buf;

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@szsam
Change storage-class of secret_buf to static
1b77cda 
Storing the address of a local variable (`secret_buf`)
in non-local memory (`prf_ptr->secret`) can cause a
dangling pointer bug if the address is used after the function returns.
@0xc0170 0xc0170 added needs: review release-type: patch Indentifies a PR as containing just a patch labels Apr 26, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented May 5, 2023

CI started

@mergify mergify bot added needs: CI and removed needs: review labels May 5, 2023
@mbed-ci
Copy link

mbed-ci commented May 5, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 70dced2 into ARMmbed:master May 5, 2023
@mergify mergify bot removed the ready for merge label May 5, 2023
@multiplemonomials multiplemonomials mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szsam @0xc0170 @mbed-ci