Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WL LoRaWAN set downlink preamble length to 8 #15459

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Oct 24, 2023

Summary of changes

Set downlink preamble length to 8 instead of 5 (like uplink), this fix downlinks issues on US915 (and may be other)

Impact of changes

Migration actions required

Documentation

See #14449


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant


Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, not verified

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Oct 24, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@hallard
Copy link
Contributor Author

hallard commented Oct 24, 2023

@0xc0170 we need to deploy some devices, could be awesome for people in charge of build if this PR could be merged. Any idea when it can be done?
Thanks.

@0xc0170 0xc0170 merged commit 7c7d20d into ARMmbed:master Oct 25, 2023
20 checks passed
@mergify mergify bot removed the ready for merge label Oct 25, 2023
@hallard hallard deleted the STM23WL_fix_preamble branch October 25, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants