Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nsapi] Fixed iar compilation issue with value initializer #2229

Merged
merged 1 commit into from
Jul 22, 2016

Conversation

geky
Copy link
Contributor

@geky geky commented Jul 22, 2016

Expression needed to init to zero a simple POD struct:

// Before (valid in C99/C++11/G++)
nsapi_addr_t addr = (nsapi_addr_t){}
// After (valid in C++03, invalid in C)
nsapi_addr_t addr = nsapi_addr_t()

cc @sg-, @c1728p9, @bridadan

Expression needed to init to zero a simple POD struct

Before (valid in C99/C++11/G++): 	(nsapi_addr_t){}
After (valid in C++03, invalid in C):	nsapi_addr_t()
@bridadan
Copy link
Contributor

/morph test

@c1728p9
Copy link
Contributor

c1728p9 commented Jul 22, 2016

Looks good to me

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 479

A build failure occurred!

@bridadan
Copy link
Contributor

Looks like some targets are too small to fit this code now (that's why there's a build failure).

I'm going to force the tests to run now from that build. I'll come back with the results when they finish.

@geky
Copy link
Contributor Author

geky commented Jul 22, 2016

Thanks @bridadan! At the very least it looks like the issue with iar was fixed.

@sg- sg- merged commit fcd03f2 into ARMmbed:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants