[nsapi] Fix missing port assignment in DNS constructor for SocketAddress #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbed-bot: TEST HOST_OSES=windows |
_stack->gethostbyname looks deceptively like it completely sets the socket address value, however port is not provided via DNS resolution.
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 698] |
|
Looks good! |
|
[Build 699] |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 516 Test failed! |
|
@bridadan why did tests report failing? Look good to me |
|
@sg- The error was caused by the issue mentioned here: #2211 (comment) I'm currently following up with Przemek about it, its looking like it may be related to mbed-ls. This PR seems ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_stack->gethostbyname looks deceptively like it completely sets the socket address value, however port is not provided via DNS resolution.
cc @sg-, @c1728p9