Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default_build from small to standard on NRF based targets with at least 32K of RAM. #2280

Merged
merged 2 commits into from
Jul 28, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 27, 2016

NRF targets with 16K of RAM keep their default_build configuration set to small.
Enabling standard build consume 5K of RAM which is huge on a platform with only 6K of RAM usable.

This PR is a follow up to #2258

least 32K of RAM.

NRF targets with 16K keep their default_build configuration set to small.
@pan-
Copy link
Member Author

pan- commented Jul 27, 2016

@sg- @bridadan

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 28, 2016

LGTM

@sg-
Copy link
Contributor

sg- commented Jul 28, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@sg-
Copy link
Contributor

sg- commented Jul 28, 2016

/morph test

@mbed-bot
Copy link

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@mbed-bot
Copy link

[Build 733]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@bridadan
Copy link
Contributor

bridadan commented Jul 28, 2016

@pan- Thanks for looking at this!

Looks like the bots caught a few issues with the NRF51_DK for GCC_ARM, mainly RTX errors:

MBED: Instrumentation: "COM59" and disk: "F:"
HOST: Copy image onto target...
        1 file(s) copied.
Looking for NRF51_DK with MBEDLS
Looking for NRF51_DK with MBEDLS
Remount complete
HOST: Initialize serial port...
Looking for NRF51_DK with MBEDLS
...port ready!
HOST: Reset target...
HOST: Property 'timeout' = '20'
HOST: Property 'host_test_name' = 'default'
HOST: Property 'description' = 'Mutex resource lock'
HOST: Property 'test_id' = 'RTOS_2'
HOST: Start test...
.RTX error code: 0x00000001, task ID: 0x20004A94

That was from the mbed 2 tests. I'm seeing similar failures for the following test cases ran with mbed test:

tests-mbedmicro-rtos-mbed-mutex

09:50:50 mbedgt: checking for 'host_tests' directory above image directory structure
09:50:50    'host_tests' directory not found: two directory levels above image path checked
09:50:50 mbedgt: selecting test case observer...
09:50:50    calling mbedhtrun: mbedhtrun -m NRF51_DK -p /dev/ttyACM4:9600 -f ".build/tests/NRF51_DK/GCC_ARM/TESTS/mbedmicro-rtos-mbed/mutex/mutex.hex" -d /media/platform-3f980000_usb-usb-0_1_3_1_4_1_0-scsi-0_0_0_0 -C 4 -c shell -t 110000004420312054434a38323035313532303397969903
09:50:50 mbedgt: mbed-host-test-runner: started
09:50:51 [1469717457.19][HTST][INF] host test executor ver. 1.1.0
09:50:51 [1469717457.19][HTST][INF] copy image onto target...
09:50:51 [1469717457.19][COPY][INF] Waiting up to 60 sec for '110000004420312054434a38323035313532303397969903' mount point (current is '/media/platform-3f980000_usb-usb-0_1_3_1_4_1_0-scsi-0_0_0_0')...
09:51:07 [1469717473.35][HTST][INF] starting host test process...
09:51:07 [1469717473.38][CONN][INF] starting connection process...
09:51:07 [1469717473.38][CONN][INF] notify event queue about extra 60 sec timeout for serial port pooling
09:51:07 [1469717473.40][CONN][INF] initializing serial port listener...
09:51:07 [1469717473.40][HTST][INF] setting timeout to: 60 sec
09:51:07 [1469717473.40][SERI][INF] serial(port=/dev/ttyACM4, baudrate=9600, timeout=0)
09:51:07 [1469717473.41][PLGN][INF] Waiting up to 60 sec for '110000004420312054434a38323035313532303397969903' serial port (current is '/dev/ttyACM4')...
09:51:07 [1469717473.59][SERI][INF] reset device using 'default' plugin...
09:51:07 [1469717473.70][SERI][INF] waiting 1.00 sec after reset
09:51:08 [1469717474.70][SERI][INF] wait for it...
09:51:08 [1469717474.70][SERI][TXD] mbedmbedmbedmbedmbedmbedmbedmbedmbedmbed
09:51:08 [1469717474.70][CONN][INF] sending up to 2 __sync packets (specified with --sync=2)
09:51:08 [1469717474.72][CONN][INF] sending preamble '617ec6ac-94f0-4d82-951b-c1c79fb57ff2'
09:51:08 [1469717474.72][SERI][TXD] {{__sync;617ec6ac-94f0-4d82-951b-c1c79fb57ff2}}
09:51:09 [1469717474.85][CONN][RXD] {{__sync;617ec6ac-94f0-4d82-951b-c1c79fb57ff2}}
09:51:09 [1469717474.86][CONN][INF] found SYNC in stream: {{__sync;617ec6ac-94f0-4d82-951b-c1c79fb57ff2}} it is #0 sent, queued...
09:51:09 [1469717474.86][HTST][INF] sync KV found, uuid=617ec6ac-94f0-4d82-951b-c1c79fb57ff2, timestamp=1469717474.856167
09:51:09 [1469717474.87][CONN][RXD] {{__version;1.3.0}}
09:51:09 [1469717474.88][CONN][INF] found KV pair in stream: {{__version;1.3.0}}, queued...
09:51:09 [1469717474.89][CONN][RXD] {{__timeout;20}}
09:51:09 [1469717474.89][HTST][INF] DUT greentea-client version: 1.3.0
09:51:09 [1469717474.90][CONN][INF] found KV pair in stream: {{__timeout;20}}, queued...
09:51:09 [1469717474.90][HTST][INF] setting timeout to: 20 sec
09:51:09 [1469717474.93][CONN][RXD] {{__host_test_name;default_auto}}
09:51:09 [1469717474.93][CONN][INF] found KV pair in stream: {{__host_test_name;default_auto}}, queued...
09:51:09 [1469717474.93][HTST][INF] host test class: '<class 'mbed_host_tests.host_tests.default_auto.DefaultAuto'>'
09:51:09 [1469717474.93][HTST][INF] host test setup() call...
09:51:09 [1469717474.93][HTST][INF] CALLBACKs updated
09:51:09 [1469717474.93][HTST][INF] host test detected: default_auto
09:51:09 [1469717474.98][CONN][RXD] .RTX error code: 0x00000001, task ID: 0x20005464
09:51:29 [1469717494.90][HTST][INF] test suite run finished after 20.00 sec...
09:51:29 [1469717494.90][CONN][INF] received special even '__host_test_finished' value='True', finishing
09:51:29 [1469717494.91][HTST][INF] CONN exited with code: 0
09:51:29 [1469717494.91][HTST][INF] No events in queue
09:51:29 [1469717494.91][HTST][INF] stopped consuming events
09:51:29 [1469717494.91][HTST][INF] host test result(): None
09:51:29 [1469717494.91][HTST][WRN] missing __exit event from DUT
09:51:29 [1469717494.91][HTST][ERR] missing __exit event from DUT and no result from host test, timeout...
09:51:29 [1469717494.91][HTST][INF] calling blocking teardown()
09:51:29 [1469717494.91][HTST][INF] teardown() finished
09:51:29 [1469717494.91][HTST][INF] {{result;timeout}}
09:51:29 mbedgt: checking for GCOV data...
09:51:29 mbedgt: mbed-host-test-runner: stopped and returned 'TIMEOUT'
09:51:29 mbedgt: test case summary event not found
09:51:29    no test case report present, assuming test suite to be a single test case!
09:51:29    test suite: tests-mbedmicro-rtos-mbed-mutex
09:51:29    test case: tests-mbedmicro-rtos-mbed-mutex
09:51:29 mbedgt: test on hardware with target id: 110000004420312054434a38323035313532303397969903
09:51:29 mbedgt: test suite 'tests-mbedmicro-rtos-mbed-mutex' ................................................. TIMEOUT in 39.03 sec
09:51:29    test case: 'tests-mbedmicro-rtos-mbed-mutex' ................................................. ERROR in 39.03 sec
09:51:29 mbedgt: test case summary: 0 passes, 1 failure

tests-mbedmicro-rtos-mbed-semaphore

09:57:06 mbedgt: checking for 'host_tests' directory above image directory structure
09:57:06    'host_tests' directory not found: two directory levels above image path checked
09:57:06 mbedgt: selecting test case observer...
09:57:06    calling mbedhtrun: mbedhtrun -m NRF51_DK -p /dev/ttyACM4:9600 -f ".build/tests/NRF51_DK/GCC_ARM/TESTS/mbedmicro-rtos-mbed/semaphore/semaphore.hex" -d /media/platform-3f980000_usb-usb-0_1_3_1_4_1_0-scsi-0_0_0_0 -C 4 -c shell -t 110000004420312054434a38323035313532303397969903
09:57:06 mbedgt: mbed-host-test-runner: started
09:57:06 [1469717832.74][HTST][INF] host test executor ver. 1.1.0
09:57:06 [1469717832.74][HTST][INF] copy image onto target...
09:57:06 [1469717832.74][COPY][INF] Waiting up to 60 sec for '110000004420312054434a38323035313532303397969903' mount point (current is '/media/platform-3f980000_usb-usb-0_1_3_1_4_1_0-scsi-0_0_0_0')...
09:57:22 [1469717848.34][HTST][INF] starting host test process...
09:57:22 [1469717848.37][CONN][INF] starting connection process...
09:57:22 [1469717848.37][CONN][INF] notify event queue about extra 60 sec timeout for serial port pooling
09:57:22 [1469717848.37][CONN][INF] initializing serial port listener...
09:57:22 [1469717848.38][SERI][INF] serial(port=/dev/ttyACM4, baudrate=9600, timeout=0)
09:57:22 [1469717848.38][PLGN][INF] Waiting up to 60 sec for '110000004420312054434a38323035313532303397969903' serial port (current is '/dev/ttyACM4')...
09:57:22 [1469717848.37][HTST][INF] setting timeout to: 60 sec
09:57:22 [1469717848.53][SERI][INF] reset device using 'default' plugin...
09:57:22 [1469717848.64][SERI][INF] waiting 1.00 sec after reset
09:57:23 [1469717849.64][SERI][INF] wait for it...
09:57:23 [1469717849.64][SERI][TXD] mbedmbedmbedmbedmbedmbedmbedmbedmbedmbed
09:57:23 [1469717849.64][CONN][INF] sending up to 2 __sync packets (specified with --sync=2)
09:57:23 [1469717849.65][CONN][INF] sending preamble '31c22a53-d7a5-47d8-9bfe-7021e83b036e'
09:57:23 [1469717849.66][SERI][TXD] {{__sync;31c22a53-d7a5-47d8-9bfe-7021e83b036e}}
09:57:24 [1469717849.80][CONN][RXD] {{__sync;31c22a53-d7a5-47d8-9bfe-7021e83b036e}}
09:57:24 [1469717849.80][CONN][INF] found SYNC in stream: {{__sync;31c22a53-d7a5-47d8-9bfe-7021e83b036e}} it is #0 sent, queued...
09:57:24 [1469717849.80][HTST][INF] sync KV found, uuid=31c22a53-d7a5-47d8-9bfe-7021e83b036e, timestamp=1469717849.798862
09:57:24 [1469717849.81][CONN][RXD] {{__version;1.3.0}}
09:57:24 [1469717849.81][CONN][INF] found KV pair in stream: {{__version;1.3.0}}, queued...
09:57:24 [1469717849.81][HTST][INF] DUT greentea-client version: 1.3.0
09:57:24 [1469717849.83][CONN][RXD] {{__timeout;20}}
09:57:24 [1469717849.83][CONN][INF] found KV pair in stream: {{__timeout;20}}, queued...
09:57:24 [1469717849.83][HTST][INF] setting timeout to: 20 sec
09:57:24 [1469717849.87][CONN][RXD] {{__host_test_name;default_auto}}
09:57:24 [1469717849.87][CONN][INF] found KV pair in stream: {{__host_test_name;default_auto}}, queued...
09:57:24 [1469717849.87][HTST][INF] host test class: '<class 'mbed_host_tests.host_tests.default_auto.DefaultAuto'>'
09:57:24 [1469717849.87][HTST][INF] host test setup() call...
09:57:24 [1469717849.87][HTST][INF] CALLBACKs updated
09:57:24 [1469717849.87][HTST][INF] host test detected: default_auto
09:57:24 [1469717849.92][CONN][RXD] 1RTX error code: 0x00000001, task ID: 0x2000545C
09:57:44 [1469717869.83][HTST][INF] test suite run finished after 20.00 sec...
09:57:44 [1469717869.83][CONN][INF] received special even '__host_test_finished' value='True', finishing
09:57:44 [1469717869.84][HTST][INF] CONN exited with code: 0
09:57:44 [1469717869.84][HTST][INF] No events in queue
09:57:44 [1469717869.84][HTST][INF] stopped consuming events
09:57:44 [1469717869.84][HTST][INF] host test result(): None
09:57:44 [1469717869.84][HTST][WRN] missing __exit event from DUT
09:57:44 [1469717869.84][HTST][ERR] missing __exit event from DUT and no result from host test, timeout...
09:57:44 [1469717869.84][HTST][INF] calling blocking teardown()
09:57:44 [1469717869.84][HTST][INF] teardown() finished
09:57:44 [1469717869.84][HTST][INF] {{result;timeout}}
09:57:44 mbedgt: checking for GCOV data...
09:57:44 mbedgt: mbed-host-test-runner: stopped and returned 'TIMEOUT'
09:57:44 mbedgt: test case summary event not found
09:57:44    no test case report present, assuming test suite to be a single test case!
09:57:44    test suite: tests-mbedmicro-rtos-mbed-semaphore
09:57:44    test case: tests-mbedmicro-rtos-mbed-semaphore
09:57:44 mbedgt: test on hardware with target id: 110000004420312054434a38323035313532303397969903
09:57:44 mbedgt: test suite 'tests-mbedmicro-rtos-mbed-semaphore' ............................................. TIMEOUT in 38.11 sec
09:57:44    test case: 'tests-mbedmicro-rtos-mbed-semaphore' ............................................. ERROR in 38.11 sec
09:57:44 mbedgt: test case summary: 0 passes, 1 failure

Note that this test (tests-mbedmicro-rtos-mbed-semaphore) also affected the NRF52_DK, but this was the RTX error that was printed:

1RTX error code: 0x00000001, task ID: 0x20005484

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 550

Test failed!

@pan-
Copy link
Member Author

pan- commented Jul 28, 2016

@bridadan This is a side effect of switching to the full printf, it takes more stack space!
The stack for every tests were tuned for small build and I forgot to update the values.
Let me fix that.

@pan-
Copy link
Member Author

pan- commented Jul 28, 2016

@sg- @bridadan could you retest this PR ?

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE,K22F

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

[Build 736]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 556

Test failed!

@pan-
Copy link
Member Author

pan- commented Jul 28, 2016

@bridadan Looking at the logs, it looks like the test succeed, I don't understand the failure here.

@bridadan
Copy link
Contributor

bridadan commented Jul 28, 2016

@pan- You're right, the FAILURE result shown by the bot and the fails highlighted by the viewer are caused by an issue in htrun. The actual test runs look good!

@sg- sg- merged commit 43bae17 into ARMmbed:master Jul 28, 2016
@pan- pan- deleted the nrf-standard-build branch September 27, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants