-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default_build from small to standard on NRF based targets with at least 32K of RAM. #2280
Conversation
least 32K of RAM. NRF targets with 16K keep their default_build configuration set to small.
LGTM |
@mbed-bot: TEST HOST_OSES=windows |
/morph test |
[Build ${MBED_BUILD_ID}] |
@mbed-bot: TEST HOST_OSES=windows |
[Build 733] |
@pan- Thanks for looking at this! Looks like the bots caught a few issues with the NRF51_DK for GCC_ARM, mainly RTX errors:
That was from the mbed 2 tests. I'm seeing similar failures for the following test cases ran with tests-mbedmicro-rtos-mbed-mutex
tests-mbedmicro-rtos-mbed-semaphore
Note that this test (tests-mbedmicro-rtos-mbed-semaphore) also affected the NRF52_DK, but this was the RTX error that was printed:
|
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 550 Test failed! |
@bridadan This is a side effect of switching to the full printf, it takes more stack space! |
@mbed-bot: TEST HOST_OSES=windows |
/morph test |
[Build 736] |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 556 Test failed! |
@bridadan Looking at the logs, it looks like the test succeed, I don't understand the failure here. |
@pan- You're right, the FAILURE result shown by the bot and the fails highlighted by the viewer are caused by an issue in htrun. The actual test runs look good! |
NRF targets with 16K of RAM keep their default_build configuration set to small.
Enabling standard build consume 5K of RAM which is huge on a platform with only 6K of RAM usable.
This PR is a follow up to #2258