-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a baud argument for (Raw)Serial objects #2422
Conversation
@mbed-bot: TEST HOST_OSES=ALL |
/morph test |
[Build ${MBED_BUILD_ID}] |
@mbed-bot: TEST HOST_OSES=ALL |
[Build 798] |
This failed because of configuration data issues, again. PR coming up. |
Will progress once #2423 is merged. |
7c61fa6
to
8016678
Compare
@mbed-bot: TEST HOST_OSES=ALL |
/morph test |
[Build 800] |
@mbed-bot: TEST HOST_OSES=windows |
You should be added now @bogdanm to the morph bot, sorry about that. /morph test |
[Build 801] |
Thanks @bridadan. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 632 Build failed! |
@bogdanm Are the issues with config resolved? If not can this be updated to just use 9600 as default? |
8016678
to
4312b0b
Compare
@sg- I've rebased this PR and force-pushed the changes. Let's see if the CI still complains about it. |
The failure from https://travis-ci.org/ARMmbed/mbed-os/builds/163444683 is very likely related to some limitations in |
@bogdanm Can you be a little more specific on what you mean by "limitations"? It looks like the config parameter isn't being declared as a macro correctly. |
@bridadan True, but only when invoking |
It's possible that the config isn't propagating correctly because that particular line travis is testing uses some of the old ways of compiling mbed 2 tests. You should be able to reproduce the failure fairly easily locally: |
@bridadan That's the limitation that I'm talking about. The problem isn't reproducing the failure locally, but rather that I'm getting an error from the CI when the code is actually correct. |
@bogdanm Gotcha, thanks for clarifying. I'd have to take a look at what exactly isn't being passed along. Not sure if I'll get to it today but I'll add it to my list. I have a feeling the culprit lies in the call to |
4312b0b
to
bc10118
Compare
Rebased again. |
@bridadan, the CI shows the same error, although now I can see the configuration file in |
@bogdanm I think the actual issue is that the |
This commit adds a `baud` argument for Serial and RawSerial objects: - there is a new `Serial` constructor with a mandatory baud rate argument. The old constructor also got a `baud` argument with a default value (to keep backward compatibility). - the `RawSerial` constructor also got a `baud` argument with a default value. There's also a new configuration parameter (`default-serial-baud-rate`) that can be used to specify the default value of the above `baud` arguments.
bc10118
to
8eb36e1
Compare
Ah thanks, I didn't realize that we changed the name of the library. Fixed. |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1039 All builds and test passed! |
This commit adds a
baud
argument for Serial and RawSerial objects:Serial
constructor with a mandatory baud rateargument. The old constructor also got a
baud
argument with adefault value (to keep backward compatibility).
RawSerial
constructor also got abaud
argument with a defaultvalue.
There's also a new configuration parameter (
default-serial-baud-rate
)that can be used to specify the default value of the above
baud
arguments.