Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for IOTCLT-961 for next mbed-os release candidate #2527

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

yogpan01
Copy link
Contributor

This PR is for fixing error found in integration testing for Bootstrap and Connector functionality.
The corresponding fixes done here
ARMmbed/mbed-client@6925e89
ARMmbed/mbed-client-classic@fbfb300

This PR is for fixing error found in integration testing for Bootstrap and Connector functionality.
The corresponding fixes done here
ARMmbed/mbed-client@6925e89
ARMmbed/mbed-client-classic@fbfb300
@yogpan01
Copy link
Contributor Author

@sg- @0xc0170 Please consider this PR for next release candidate of mbed-os

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2016

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 722

All builds and test passed!

@jupe
Copy link
Contributor

jupe commented Aug 29, 2016

This breaks mbed-client-classic build.. Problematic commit is this one:
ARMmbed/mbed-client-classic@e35a2ae

@tommikas
Copy link
Contributor

I think the specific line that breaks the builds is this: https://github.com/ARMmbed/mbed-os/pull/2527/files#diff-d62a3ea84a2a42fc1bf16f8fa83b4725L30

@sg-
Copy link
Contributor

sg- commented Aug 29, 2016

@geky @yogpan01 please have a look at this and confirm

@geky
Copy link
Contributor

geky commented Aug 29, 2016

Can confirm that line was needed for the MemoryPool, not sure why it was removed when merged into mbed-os.

@geky
Copy link
Contributor

geky commented Aug 29, 2016

It looks like @yogpan01 was on top of this issue and has already merged a fix: #2570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants