Initial ports for u-blox C029/EVK-ODIN-W2 and HI2110. #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the NBIOT chip), SARA_NBIOT (the NBIOT module that contains the HI2110 chip) and SARA_NBIOT_EVK (the board that carries SARA_NBIOT). The code compiles and runs but there are know bugs in that us_ticker stops working correctly after about 10 seconds and it doesn't yet receive characters correctly.
… was because the disable interrupt and clear interrupt calls were disabling and clearing the timer interrupt but in fact, because the interrupt is needed to manage timer overflow in our case, it should not be disabled/cleared. Instead these calls now simply stop the user interrupts from occurring, which is all they need to do.
This reverts commit 40e2f36.
|
Something to note: The targets in this PR won't be built/tested in CI until the |
|
Anything more we should do to get this tested in CI(UBLOX_C029 target only) and integrated? |
|
I did a brief check to make sure none of the changes looked out of place and this looked ok. @0xc0170 Should probably take a look at this too. It looks like this has merge conflicts as well, so it will need to be rebased before it gets merged. |
|
@andreaslarssonublox needs a rebase |
| @@ -1163,14 +1163,16 @@ | |||
| "UBLOX_C029": { | |||
| "supported_form_factors": ["ARDUINO"], | |||
| "core": "Cortex-M4F", | |||
| "default_toolchain": "uARM", | |||
| "default_toolchain": "GCC_ARM", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.