-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network echo test host scripts for Mac #3436
Conversation
Is it possible to fall back to 8000 only after the exception? This patch prevents multiple network tests from running in parallel on the same machine. Guess: try:
s.connect((target_ip, 0))
except socket.error:
s.connect((target_ip, 8000)) |
Fixed now. |
retest uvisor |
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
Maintainers: please hold off on restarting tests for this, I added a new platform to the CI and it caused the failure. I will restart this when I've resolved the problem. |
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@marhil01 The failure for pr-head : |
retest uvisor |
cc @VeliMattiLahtela about the CI failure. |
most probably this PR based too old mbed-os baseline which has bugs and that why some tests fails now. Especially this fix is now missing: #3193. Please rebase/merge against master head to see if last ci passes. |
@bulislaw would you mind rebasing this on top of master to confirm @jupe's suggestion? @jupe, ideally the Oulu CI would merge this PR into the latest master of mbed-os, then run all of its tests. That's what we do on the rest of our CI setups. This has helped us move quickly and reduce the number of rebases that contributors have to do. Do you think this would be possible? |
It seems that the 0 aka 'any port' doesn't work well on Mac, causing [Errno 49] Can't assign requested address errors.
The 0 aka 'any' port doesn't for on Mac, but, only, using defined port may interfere with running multiple tests on CI.
76716b8
to
b77f663
Compare
Done |
Thanks @jupe for the tip. All green ! |
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Status
READY
It seems that the 0 aka 'any port' doesn't work well on Mac, causing
[Errno 49] Can't assign requested address errors.
This PR makes connection to a random port (8000) to get the local if address.
CC: @geky @bridadan