Removing default toolchain paths #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was spurred by a confusing error. I attempted to compile for the RZ_A1H (a Cortex-A device), and I had the standalone ARM compiler in my system path, which supports Cortex-A. However, the default path for the ARM compiler in settings.py uses a Keil installation, which only supports Cortex-M. It found my Keil installation and used that instead. This change proposes to remove this default behavior and instead requires the user to explicitly set the intended compiler, either by a settings file, mbed CLI, environment variables, or by placing the compiler in your PATH.
sg-
reviewed
Dec 20, 2016
|
@sg- Yes, after removing the compilers from my PATH and renaming my Keil installation folder, I was able to get an error from the tools: |
theotherjimmy
approved these changes
Dec 20, 2016
|
@miklis is this affecting to our CI infra? |
|
@jupe, good catch, thanks for checking this |
miklis
approved these changes
Dec 21, 2016
bulislaw
approved these changes
Dec 21, 2016
|
retest uvisor |
0xc0170
approved these changes
Dec 21, 2016
|
/morph test |
|
@mbed-bot: TEST |
|
[Build 1189] |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was spurred by a confusing error. I attempted to compile for the RZ_A1H (a Cortex-A device), and I had the standalone ARM compiler in my system path, which supports Cortex-A. However, the default path for the ARM compiler in settings.py uses a Keil installation, which only supports Cortex-M. It found my Keil installation and used that instead, causing a compiler error. This change proposes to remove this default behavior and instead requires the user to explicitly set the intended compiler path, either by a settings file, mbed CLI, environment variables, or by placing the compiler in your PATH.
Status
READY
Migrations
YES
This will now require that a user sets the compiler paths via mbed CLI, environment variables, settings files, or by placing them in the system PATH.
I realize this could be a breaking change for some developers, so perhaps we should wait a release before doing this? We could detect that the default path in settings.py is being used and warn the users to set the compiler path explicitly. Open to suggestions here!
Todos
Notes to Maintainers
I requested a lot of reviewers on this PR since this is changing some legacy behavior that we've had for quite some time now. It'd be good to get input from everyone since this may affect many different parts of the mbed ecosystem.