Dev stm factorize gpio #3575
Merged
Dev stm factorize gpio #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpio_object.h is included from common_objects.h, so no need to have it here.
Let's make the code more common for gpios. The only difference between STM32 families is that BRR register may not be available. In case BRR is not available, we use the 16 left bits of BSRR instead. We could always use BSRR, but BRR saves one left-shift operation, so let's use it when available. By default we will consider using BRR, except for platforms that define GPIO_IP_WITHOUT_BRR.
|
I love PRs like these, such a beautiful diff! 😄 Thanks @LMESTM! /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
bridadan
approved these changes
Jan 13, 2017
0xc0170
added
ready for merge
release-version: 5.3.4
and removed
needs: review
ready for merge
labels
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 3571: DISCO_F769NI introduction ARMmbed/mbed-os#3571 3605: Add DELTA_DFCM_NNN50 platform ARMmbed/mbed-os#3605 3640: [MAX32630FTHR] Adding new platform ARMmbed/mbed-os#3640 Fixes and Changes 3397: Add uVisor support for the DISCO_F429ZI ARMmbed/mbed-os#3397 3573: fix failing RTC initialization for MTS_DRAGONFLY_F411RE ARMmbed/mbed-os#3573 3575: Dev stm factorize gpio ARMmbed/mbed-os#3575 3584: STM32: make PeripheralPins.h a common file ARMmbed/mbed-os#3584 3583: STM32F7 Cube FW new release v1.5.1 ARMmbed/mbed-os#3583 3578: Target system - Inherit names from target parents ARMmbed/mbed-os#3578 3599: K22F: Enable TRNG ARMmbed/mbed-os#3599 3614: STM32: make PortNames.h a common file ARMmbed/mbed-os#3614 3617: EFM32GG: Fix GCC_ARM linker script ARMmbed/mbed-os#3617 3618: STM32: Move types definitions to a common file ARMmbed/mbed-os#3618 3631: F3 CUBE update V1.7.0 ARMmbed/mbed-os#3631 3635: STM32 I2C : Fix bug in i2c_byte_read function ARMmbed/mbed-os#3635 3651: Max32630 - fix LED4 ARMmbed/mbed-os#3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR factorizes some code and makes 2 x 9 duplicated files into 2 files only
Status
READY
Test Report
Non regression tested with ci test shield so that GPIOs are tested
F410RB
BEFORE PR
mbedgt: test case results: 1 FAIL / 33 OK / 3 ERROR
AFTER PR
mbedgt: test case results: 1 FAIL / 33 OK / 3 ERROR
F103RB
BEFORE PR
mbedgt: test case results: 38 OK / 2 ERROR
AFTER PR
mbedgt: test case results: 38 OK / 2 ERROR
L476RG
BEFORE PR
mbedgt: test case results: 2 FAIL / 34 OK / 3 ERROR
AFTER PR
mbedgt: test case results: 2 FAIL / 34 OK / 3 ERROR
F207ZG
BEFORE PR
mbedgt: test case results: 2 FAIL / 37 OK / 3 ERROR
AFTER PR
mbedgt: test case results: 2 FAIL / 37 OK / 3 ERROR