NCS36510: I2C idle delay of 1us is added between I2C commands as I2C_… #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…COMMAND_FIFO is too fast to push commands out.
sg-
suggested changes
Feb 9, 2017
| @@ -135,15 +136,15 @@ void fI2cFrequency(i2c_t *obj, uint32_t hz) | |||
| int32_t fI2cStart(i2c_t *obj) | |||
| { | |||
| /* Send start bit */ | |||
| obj->membase->CMD_REG = I2C_CMD_START; | |||
| SEND_COMMAND(I2C_CMD_START) | |||
There was a problem hiding this comment.
Ooops. Thank goodness for Travis CI 👍
|
@sg Actually semicolon present in macro definition. Any how committed with semicolon. |
|
This PR needs rebase to resolve a bug that is fixed on master already. I'll take this patch and send a new one |
|
@pradeep-gr New Pr referenced, please review I'll close this one |
|
@0xc0170 Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I2C idle delay of 1us is added between I2C commands as I2C_COMMAND_FIFO is too fast to push commands out.
Status
READY
Migrations
This PR resolves I2C issue mentioned in #3511
Related PRs
This PR is one of the feature from #3611. So PR #3611 will be invalid and can be closed.
Todos
Deploy notes
No changes required
Steps to test or reproduce
Run I2C ci-test-shield tests