Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCS36510: SPISLAVE enabled #3724

Closed
wants to merge 0 commits into from

Conversation

pradeep-gr
Copy link
Contributor

Description

SPISLAVE enabled.

Status

READY

Migrations

SPI slave features can be used.

Related PRs

This PR is one of the feature(SPISLAVE) from #3611. So PR #3611 will be invalid and can be closed.

Todos

  • Tests

Deploy notes

No changes required

Steps to test or reproduce

Can be tested with SPISLAVE ci-test-shield tests

@pradeep-gr
Copy link
Contributor Author

cc @danish-iftikhar @maclobdell

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about testing for this enablement?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 9, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Feb 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1541

All builds and test passed!

@0xc0170 0xc0170 removed the needs: CI label Feb 9, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 9, 2017

Just to be certain, we would like to know how was this tested, if any test reports can be provided.

@pradeep-gr
Copy link
Contributor Author

@0xc0170 One of the NCS36510 mbed board used as master and one more as slave and tried to exchange data between them. No report maintained, tried basic data exchange.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 23, 2017

please resolve conflicts (sorry for the delay)

@pradeep-gr
Copy link
Contributor Author

@0xc0170
Please close this PR. Use #3831 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants