Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 remove warning in hal_tick_32b.c file #3741

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

jeromecoutant
Copy link
Collaborator

Description

Remove warning in TARGET_STM/hal_tick_32b.c
Add debug capability
Astyle run

Status

READY

@sg-
Copy link
Contributor

sg- commented Feb 13, 2017

I'd prefer we add a unified debug method before taking this. Sure there are examples where this exists but I'd suggest we dont take more, rather, start a common implementation.

@bridadan
Copy link
Contributor

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2017

I restarted travis as I could not see the failure. @jeromecoutant please have a look once it finishes.

Regarding debug msg, I would leave it out from this patch. As written in another PR, we should have a generalized API for that, so alll of us can benefit from it. Please create an issue and we should have a look at it.

@jeromecoutant
Copy link
Collaborator Author

Debug messages have been removed, and rebase done.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2017

Debug messages have been removed, and rebase done.

Thanks !

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1668

All builds and test passed!

@bridadan
Copy link
Contributor

I'm guessing because this is such a minor change that we don't have to review much, but the final call is up to you @0xc0170 😄

@jeromecoutant
Copy link
Collaborator Author

Forgot to merge ? :-)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 2, 2017

Forgot to merge ? :-)

Looks like that . I;'ll reapply a label to a new release version. Thanks for the reminder

@0xc0170 0xc0170 merged commit 750ac51 into ARMmbed:master Mar 6, 2017
@jeromecoutant jeromecoutant deleted the PR_TICK32 branch March 6, 2017 16:52
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

3716: fix for issue #3715: correction in startup files for ARM and IAR, alignment of system_stm32f429xx.c files ARMmbed/mbed-os#3716
3741: STM32 remove warning in hal_tick_32b.c file ARMmbed/mbed-os#3741
3780: STM32L4 : Fix GPIO G port compatibility ARMmbed/mbed-os#3780
3831: NCS36510: SPISLAVE enabled (Conflict resolved) ARMmbed/mbed-os#3831
3836: Allow to redefine nRF's PSTORAGE_NUM_OF_PAGES outside of the mbed-os ARMmbed/mbed-os#3836
3840: STM32: gpio SPEED - always set High Speed by default ARMmbed/mbed-os#3840
3844: STM32 GPIO: Typo correction. Update comment (GPIO_IP_WITHOUT_BRR) ARMmbed/mbed-os#3844
3850: STM32: change spi error to debug warning ARMmbed/mbed-os#3850
3860: Define GPIO_IP_WITHOUT_BRR for xDot platform ARMmbed/mbed-os#3860
3880: DISCO_F469NI: allow the use of CAN2 instance when CAN1 is not activated ARMmbed/mbed-os#3880
3795: Fix pwm period calc ARMmbed/mbed-os#3795
3828: STM32 CAN API: correct format and type ARMmbed/mbed-os#3828
3842: TARGET_NRF: corrected spi_init() to properly handle re-initialization ARMmbed/mbed-os#3842
3843: STM32L476xG: set APB2 clock to 80MHz (instead of 40MHz) ARMmbed/mbed-os#3843
3879: NUCLEO_F446ZE: Add missing AnalogIn pins on PF_3, PF_5 and PF_10. ARMmbed/mbed-os#3879
3902: Fix heap and stack size for NUCLEO_F746ZG ARMmbed/mbed-os#3902
3829: can_write(): return error code when no tx mailboxes are available ARMmbed/mbed-os#3829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants