Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix of initial value of interrupt edge in "gpio_irq_init" again #3803

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Bug fix of initial value of interrupt edge in "gpio_irq_init" again #3803

merged 1 commit into from
Feb 22, 2017

Conversation

TomoYamanaka
Copy link
Contributor

I modified the bug in PR #3289. But It seems not enough the changes.
For the reason, It occured the following issue.
#3694
So I reviewed and re-modified about the setting of initial value of interrupt edge in "gpio_irq_init".

@TomoYamanaka
Bug fix of initial value of interrupt edge in "gpio_irq_init" again
d1866f2 
I modified the bug in PR ARMmbed#3289. But It seems not enough the changes.
For the reason, It occured the following issue.
ARMmbed#3694
So I reviewed and re-modified about the setting of initial value of interrupt edge in "gpio_irq_init".
@TomoYamanaka TomoYamanaka mentioned this pull request Feb 20, 2017
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 20, 2017

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 20, 2017

@TomoYamanaka How was this tested? any interruptIn test done?

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1655

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 20, 2017

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2017

@TomoYamanaka please provide details (tests and why it was removed) - who enables that IRQ now? It's not clear from the commit message.

@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented Feb 22, 2017 •
edited
Loading

@0xc0170

IRQ is enabled the two API of InterruptIn (InterruptIn::rise / InterruptIn::fall).
In the processing so far, IRQ was enabled at gpio_irq_init and gpio_irq_set (InterruptIn::rise / InterruptIn::fall) execution. But, when IRQ was enabled in initial processing, it occurred the issue that interrupt enters in the timing of constructor of IntrruptIn.
Since the IRQ enable timing is not only the initial processing, but also when InterruptIn::rise / InterruptIn::fall are executed, so I removed the IRQ enable in the initial processing.

@sg- sg- merged commit 5491ccc into ARMmbed:master Feb 22, 2017
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 137 of the mbed library
20a980c 
Ports for Upcoming Targets


Fixes and Changes

3590: [NUC472/M453] Export IAR project and other bugfixes ARMmbed/mbed-os#3590
3740: STM32L4 HAL update for RTC Wake Up Timer ARMmbed/mbed-os#3740
3739: STM32F7 : remove multiple HSE_VALUE define value ARMmbed/mbed-os#3739
3759: STM32: spi_frequency table index fix ARMmbed/mbed-os#3759
3779: NCS36510: Fix the sporadic semaphore timing issue ARMmbed/mbed-os#3779
3806: NXP KL43Z/KL27Z: fix spi format bits check ARMmbed/mbed-os#3806
3814: NCS36510: I2C idle delay of 1us ARMmbed/mbed-os#3814
3803: Bug fix of initial value of interrupt edge in "gpio_irq_init" again ARMmbed/mbed-os#3803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomoYamanaka @0xc0170 @mbed-bot @sg- @bridadan