STM32L4 ADC correct internal channel management #6412
Conversation
|
/morph build |
Build : SUCCESSBuild number : 1518 Triggering tests/morph test |
| /* Configuration of common ADC parameters */ | ||
| /* If the requested internal measurement path has already been enabled, */ | ||
| /* bypass the configuration processing. */ | ||
| if (( (sConfig->Channel == ADC_CHANNEL_TEMPSENSOR) && |
There was a problem hiding this comment.
Interesting. So configuration of the internal channels doesn't require that the ADC be in RESET mode?
There was a problem hiding this comment.
configuration of the internal channels doesn't require that the ADC be in RESET mode?
Yes, ADC driver team explained me that restriction is no more valid since last reference manual version.
Official correction will come in the next cube release.
| /* of the common group are disabled. */ | ||
| if ((ADC_IS_ENABLE(hadc) == RESET) && | ||
| (ADC_ANY_OTHER_ENABLED(hadc) == RESET) ) | ||
| if (ADC_TEMPERATURE_SENSOR_INSTANCE(hadc)) |
There was a problem hiding this comment.
Does this imply that ADC parameters can now be changed without all ADCs needing to be in reset (per the deleted comment)?
Exporter Build : SUCCESSBuild number : 1158 |
Test : SUCCESSBuild number : 1296 |
Description
Issue detected in #6398
Only 1 internal channel could be configured which was wrong.
@maskedw
Pull request type