Fix _sbrk() implementation for Cortex-M parts. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit, 43acaa4, to get _sbrk() to build successfully for LPC2368 broke the Cortex-M implementation. __get_MSP() isn't ever defined as a macro, it is an inline function. This means that the code would always be compiled to use SP instead of MSP on Cortex-M parts. I switched the code to instead use the TARGET_ARM7 define to choose which stack pointer to utilize. I tested this fix by making sure that the LPC2368 version of the mbed SDK would still build successfully with the Python scripts and that the NET1 test still built and ran successfully on my mbed-LPC1768 device.
emilmont
added a commit
that referenced
this pull request
Sep 17, 2013
Fix _sbrk() implementation for Cortex-M parts.
artokin
pushed a commit
to artokin/mbed-os
that referenced
this pull request
Aug 23, 2017
… from e125164..d65b6b0 d65b6b0 Update unittests for nsdynmemlib API change (ARMmbed#71) bc69b8b Disable CoAP duplicate message detection (ARMmbed#69) ccb65f8 Change year 2017 to copyright (ARMmbed#68) 76490a7 Add option to join COAP multicast group (ARMmbed#67) 381d910 Register to multicast groups (ARMmbed#66) dce323c Add transaction delete to CoAP service (ARMmbed#65) feea33e Add option to select used socket interface (ARMmbed#63) 5a5c0f9 Merge pull request ARMmbed#62 from ARMmbed/coap_separation 0d26c00 Modifying file headers and Makefile to adapt from libcoap to mbed-coap d323c3a Fixing unit tests based on new coap library d1a3d25 Modifying Makefile and source file based on new coap library git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service git-subtree-split: d65b6b0
artokin
pushed a commit
to artokin/mbed-os
that referenced
this pull request
Aug 23, 2017
…9c..b731d95 b731d95 Clarify mutex type requirement (ARMmbed#77) 7c31aef bumb version number (ARMmbed#72) 75982fc fix dummydefine for mbed_trace_init (ARMmbed#71) 539b80c Update version number. (ARMmbed#69) b0e09f9 output/ added to gitignore list (ARMmbed#66) a5cce88 Added include_directories(${CMAKE_CURRENT_SOURCE_DIR}/) include to resolve compilation error for Linux. (ARMmbed#63) d087dbb Ensure tr_array doesn't print <null> when len == 0 (ARMmbed#65) git-subtree-dir: features/FEATURE_COMMON_PAL/mbed-trace git-subtree-split: b731d954d111d92199b2a0402dc9a3d52f5d4a17
linlingao
added a commit
to linlingao/mbed-os
that referenced
this pull request
Jul 12, 2019
Port flash API
pan-
added a commit
to pan-/mbed
that referenced
this pull request
May 29, 2020
Improve documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit, 43acaa4, to get _sbrk() to build successfully for
LPC2368 broke the Cortex-M implementation. __get_MSP() isn't ever
defined as a macro, it is an inline function. This means that the
code would always be compiled to use SP instead of MSP on Cortex-M
parts. I switched the code to instead use the TARGET_ARM7 define
to choose which stack pointer to utilize.
I tested this fix by making sure that the LPC2368 version of the mbed
SDK would still build successfully with the Python scripts and that the
NET1 test still built and ran successfully on my mbed-LPC1768 device.