Flash API: Enable Flash api on CM3DS #7042

shuoo · 2018-05-29T10:33:55Z

Description

Implement flash APIs for CM3DS on MPS2+. This function is necessary for IAP and other flash related operations.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

0xc0170 · 2018-06-04T13:17:19Z

This needs rebase to contain only one commit that is now relevant (dependency was merged)

cmonr · 2018-06-13T17:02:27Z

@hug-dev Could you take a look at this PR?

hug-dev · 2018-06-13T17:13:12Z

@cmonr Yes sure, we were discussing privately with @shuoo

We will try to execute the Greentea tests on CM3DS with this pull request to ensure everything is ok and then I will approve 👌

cmonr · 2018-06-13T17:47:32Z

Oh, thanks for the update. Just making sure this PR hadn't gone idle :)

cmonr · 2018-06-29T02:54:30Z

@hug-dev Another idle check. Any luck with greentea tests?

shuoo · 2018-06-29T03:00:38Z

Greetea test environment on my PC has some problems, I will check with @hug-dev if he has the proper environment to verify this patch.

@cmonr , Do you know the details of the error for cannot be built? I got 404 when click on Details of this error.

cmonr · 2018-07-03T13:35:45Z

@shuoo The reason it's 404'd is because the log was rotated out within Jenkins. I've restarted the job for the time being. I would focus on fixing the idle bug, for now.

cmonr · 2018-07-03T14:40:12Z

@shuoo This has just passed pr-head tests. Are y'all still having dificulties getting this patch to pass greentea tests?

shuoo · 2018-07-04T11:08:38Z

With the help of @hug-dev and @tkaman , I'v run flash related test on CM3DS with MPS2 board. This commit may still can not built by CI because of blocked by other platform's flash test. @cmonr If it fails, can you please help to send the details of failure to us?

Here are the logs from terminal:
Flash Test:
{{__version;1.3.0}}
{{__timeout;20}}
{{__host_test_name;default_auto}}
{{__testcase_count;5}}

Running 5 test cases...
{{__testcase_name;Flash - init}}
{{__testcase_name;Flash - mapping alignment}}
{{__testcase_name;Flash - erase sector}}
{{__testcase_name;Flash - program page}}
{{__testcase_name;Flash - clock and cache test}}

Running case #1: 'Flash - init'...
{{__testcase_start;Flash - init}}
{{__testcase_finish;Flash - init;1;0}}
'Flash - init': 1 passed, 0 failed

Running case #2: 'Flash - mapping alignment'...
{{__testcase_start;Flash - mapping alignment}}
{{__testcase_finish;Flash - mapping alignment;1;0}}
'Flash - mapping alignment': 1 passed, 0 failed

Running case #3: 'Flash - erase sector'...
{{__testcase_start;Flash - erase sector}}
{{__testcase_finish;Flash - erase sector;1;0}}
'Flash - erase sector': 1 passed, 0 failed

Running case #4: 'Flash - program page'...
{{__testcase_start;Flash - program page}}
{{__testcase_finish;Flash - program page;1;0}}
'Flash - program page': 1 passed, 0 failed

Running case #5: 'Flash - clock and cache test'...
{{__testcase_start;Flash - clock and cache test}}
{{__testcase_finish;Flash - clock and cache test;1;0}}
'Flash - clock and cache test': 1 passed, 0 failed

Test cases: 5 passed, 0 failed
{{__testcase_summary;5;0}}
{{max_heap_usage;0}}
{{reserved_heap;0}}
{{end;success}}
{{__exit;0}}

FlashIAP Test:
{{__version;1.3.0}}
{{__timeout;20}}
{{__host_test_name;default_auto}}
{{__testcase_count;4}}

Running 4 test cases...
{{__testcase_name;FlashIAP - init}}
{{__testcase_name;FlashIAP - program}}
{{__testcase_name;FlashIAP - program across sectors}}
{{__testcase_name;FlashIAP - program errors}}

Running case #1: 'FlashIAP - init'...
{{__testcase_start;FlashIAP - init}}
{{__testcase_finish;FlashIAP - init;1;0}}
'FlashIAP - init': 1 passed, 0 failed

Running case #2: 'FlashIAP - program'...
{{__testcase_start;FlashIAP - program}}
{{__testcase_finish;FlashIAP - program;1;0}}
'FlashIAP - program': 1 passed, 0 failed

Running case #3: 'FlashIAP - program across sectors'...
{{__testcase_start;FlashIAP - program across sectors}}
{{__testcase_finish;FlashIAP - program across sectors;1;0}}
'FlashIAP - program across sectors': 1 passed, 0 failed

Running case #4: 'FlashIAP - program errors'...
{{__testcase_start;FlashIAP - program errors}}
{{__testcase_finish;FlashIAP - program errors;1;0}}
'FlashIAP - program errors': 1 passed, 0 failed

Test cases: 4 passed, 0 failed
{{__testcase_summary;4;0}}
{{max_heap_usage;0}}
{{reserved_heap;0}}
{{end;success}}
{{__exit;0}}

cmonr · 2018-07-05T18:52:06Z

Going to see what CI tests output since CI usage is low atm.
/morph build

mbed-ci · 2018-07-05T21:19:37Z

Build : ABORTED

Build number : 2538
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7042/

cmonr · 2018-07-05T22:04:33Z

/morph build

mbed-ci · 2018-07-06T00:25:18Z

Build : SUCCESS

Build number : 2543
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7042/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-07-06T02:32:57Z

Exporter Build : SUCCESS

Build number : 2187
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7042/

mbed-ci · 2018-07-06T02:52:12Z

Test : SUCCESS

Build number : 2298
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7042/2298

cmonr · 2018-07-06T14:47:05Z

/morph mbed2-build

cmonr · 2018-07-06T15:03:00Z

@mbed-os-hal Last chance to take a look at this before it goes in!

ithinuel · 2018-07-09T10:39:30Z

targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/objects.h

@@ -70,6 +70,11 @@ struct analogin_s {
    uint16_t ctrl_register;  /* Control bits with the channel identifier */
 };

+/* This structure is not used by the HAL implementation. */
+struct flash_s {
+    uint32_t not_used;


I guess this field is defined for compatibility with IAR and ARMC5 but for consistency shouldn't it be a uint8_t like in struct trng_s ?

Use uint8_t for consistent.

0xc0170 · 2018-07-09T10:42:18Z

@mbed-os-hal Last chance to take a look at this before it goes in!

@c1728p9 Please review this use case

Implement flash_api.c for CM3DS on MPS2+. Because MPS2+ board has no physical flash chip, the implementation emulates flash over SRAM.

cmonr · 2018-07-11T03:09:04Z

/morph build

mbed-ci · 2018-07-11T04:01:55Z

Build : SUCCESS

Build number : 2562
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7042/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-07-11T05:59:32Z

Test : SUCCESS

Build number : 2317
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7042/2317

mbed-ci · 2018-07-11T06:56:46Z

Exporter Build : SUCCESS

Build number : 2207
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7042/

cmonr · 2018-07-11T12:43:10Z

/morph mbed2-build

Flash API: Enable Flash api on CM3DS

0xc0170 added needs: review needs: preceding PR and removed needs: preceding PR labels May 29, 2018

0xc0170 added needs: work and removed needs: review labels Jun 4, 2018

shuoo force-pushed the feature-cm3ds-flash branch from b3b51be to 2d50b26 Compare June 6, 2018 08:46

cmonr requested a review from hug-dev June 7, 2018 15:25

cmonr added needs: review and removed needs: work labels Jun 7, 2018

shuoo force-pushed the feature-cm3ds-flash branch from 2d50b26 to 9b46fc7 Compare June 28, 2018 14:56

shuoo force-pushed the feature-cm3ds-flash branch from 9b46fc7 to 0dca412 Compare July 4, 2018 11:01

0xc0170 requested a review from a team July 4, 2018 12:03

hug-dev previously approved these changes Jul 5, 2018

View reviewed changes

ithinuel reviewed Jul 9, 2018

View reviewed changes

Flash API: Enable Flash api on CM3DS

bbb97c8

Implement flash_api.c for CM3DS on MPS2+. Because MPS2+ board has no physical flash chip, the implementation emulates flash over SRAM.

shuoo dismissed hug-dev’s stale review via bbb97c8 July 9, 2018 13:08

shuoo force-pushed the feature-cm3ds-flash branch from 0dca412 to bbb97c8 Compare July 9, 2018 13:08

c1728p9 approved these changes Jul 9, 2018

View reviewed changes

hug-dev approved these changes Jul 9, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Jul 11, 2018

ithinuel approved these changes Jul 11, 2018

View reviewed changes

cmonr added release-version: 5.9.3 ready for merge and removed needs: CI labels Jul 11, 2018

cmonr merged commit c669655 into ARMmbed:master Jul 11, 2018

0xc0170 removed the ready for merge label Jul 11, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7042 from shuoo/feature-cm3ds-flash

f519441

Flash API: Enable Flash api on CM3DS

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flash API: Enable Flash api on CM3DS #7042

Flash API: Enable Flash api on CM3DS #7042

shuoo commented May 29, 2018 •

edited

Loading

0xc0170 commented Jun 4, 2018

cmonr commented Jun 13, 2018

hug-dev commented Jun 13, 2018

cmonr commented Jun 13, 2018

cmonr commented Jun 29, 2018

shuoo commented Jun 29, 2018

cmonr commented Jul 3, 2018

cmonr commented Jul 3, 2018

shuoo commented Jul 4, 2018

cmonr commented Jul 5, 2018

mbed-ci commented Jul 5, 2018

cmonr commented Jul 5, 2018

mbed-ci commented Jul 6, 2018

mbed-ci commented Jul 6, 2018

mbed-ci commented Jul 6, 2018

cmonr commented Jul 6, 2018

cmonr commented Jul 6, 2018

ithinuel Jul 9, 2018

shuoo Jul 9, 2018

0xc0170 commented Jul 9, 2018

cmonr commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

cmonr commented Jul 11, 2018

Flash API: Enable Flash api on CM3DS #7042

Flash API: Enable Flash api on CM3DS #7042

Conversation

shuoo commented May 29, 2018 • edited Loading

Description

Pull request type

0xc0170 commented Jun 4, 2018

cmonr commented Jun 13, 2018

hug-dev commented Jun 13, 2018

cmonr commented Jun 13, 2018

cmonr commented Jun 29, 2018

shuoo commented Jun 29, 2018

cmonr commented Jul 3, 2018

cmonr commented Jul 3, 2018

shuoo commented Jul 4, 2018

cmonr commented Jul 5, 2018

mbed-ci commented Jul 5, 2018

cmonr commented Jul 5, 2018

mbed-ci commented Jul 6, 2018

Triggering tests

mbed-ci commented Jul 6, 2018

mbed-ci commented Jul 6, 2018

cmonr commented Jul 6, 2018

cmonr commented Jul 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Jul 9, 2018

cmonr commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

Triggering tests

mbed-ci commented Jul 11, 2018

mbed-ci commented Jul 11, 2018

cmonr commented Jul 11, 2018

shuoo commented May 29, 2018 •

edited

Loading