-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable LSE for MTB_USI_WM_BN_BM_22 #7446
Disable LSE for MTB_USI_WM_BN_BM_22 #7446
Conversation
This fixes #6591 for MTB_USI_WM_BN_BM_22 target. |
targets/targets.json
Outdated
@@ -1193,6 +1193,7 @@ | |||
} | |||
}, | |||
"MTB_USI_WM_BN_BM_22": { | |||
"overrides": {"lse_available": 0}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kivaisan ..
- I think this will also be the case for MTB_ADV_WISE_1530 as well. Can you please check the schematics for 1530 and move this to the parent target if suitable?
- Minor nit on coding standards.. can you please follow coding conventions for 1 statement per line?
Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so external xtal is not in use.
@ashok-rao WISE-1530 RTC tests (atleast the ones reported in MBEDOSTEST-24) works ok with LSE. And according to its datasheet, it should have the external xtal installed. Therefore I wouldn't put the setting to parent but just to module specific configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kivaisan
/morph build |
Build : SUCCESSBuild number : 2565 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2209 |
Test : SUCCESSBuild number : 2319 |
…BN_BM_22 Disable LSE for MTB_USI_WM_BN_BM_22
Description
Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so
external xtal is not in use.
Pull request type