Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LSE for MTB_USI_WM_BN_BM_22 #7446

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Disable LSE for MTB_USI_WM_BN_BM_22 #7446

merged 1 commit into from
Jul 11, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Jul 9, 2018

Description

Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so
external xtal is not in use.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

kivaisan commented Jul 9, 2018

This fixes #6591 for MTB_USI_WM_BN_BM_22 target.

@0xc0170 0xc0170 requested a review from ashok-rao July 9, 2018 12:44
@@ -1193,6 +1193,7 @@
}
},
"MTB_USI_WM_BN_BM_22": {
"overrides": {"lse_available": 0},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kivaisan ..

  1. I think this will also be the case for MTB_ADV_WISE_1530 as well. Can you please check the schematics for 1530 and move this to the parent target if suitable?
  2. Minor nit on coding standards.. can you please follow coding conventions for 1 statement per line?

Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so
external xtal is not in use.
@kivaisan
Copy link
Contributor Author

@ashok-rao WISE-1530 RTC tests (atleast the ones reported in MBEDOSTEST-24) works ok with LSE. And according to its datasheet, it should have the external xtal installed. Therefore I wouldn't put the setting to parent but just to module specific configuration.
Also modified the commit to follow coding standards.

Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kivaisan

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Build number : 2565
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7446/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@cmonr cmonr merged commit dc946b3 into ARMmbed:master Jul 11, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 11, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
…BN_BM_22

Disable LSE for MTB_USI_WM_BN_BM_22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants