Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Orbit Validation for SRG Time Series #2459

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Conversation

AndrewPlayer3
Copy link
Contributor

No description provided.

@AndrewPlayer3 AndrewPlayer3 requested a review from a team as a code owner October 15, 2024 20:43
@@ -179,6 +179,23 @@ def check_granules_intersecting_bounds(job, granule_metadata):
)


def check_same_relative_orbits(job, granule_metadata):
relative_orbit_number = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reccommend we name this previous_relative_orbit.

absolute_orbit = name_split[7]
# "Relationship between relative and absolute orbit numbers": https://sentiwiki.copernicus.eu/web/s1-products
offset = 73 if name_split[0] == 'S1A' else 27
relative_orbit = str(((int(absolute_orbit) - offset) % 175) + 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
relative_orbit = str(((int(absolute_orbit) - offset) % 175) + 1)
relative_orbit = ((int(absolute_orbit) - offset) % 175) + 1

@AndrewPlayer3 AndrewPlayer3 merged commit 11de54a into srg Oct 16, 2024
10 checks passed
@AndrewPlayer3 AndrewPlayer3 deleted the srg-validators branch October 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants