Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

158 replace class callback by function #331

Merged
merged 5 commits into from
Dec 13, 2019
Merged

158 replace class callback by function #331

merged 5 commits into from
Dec 13, 2019

Conversation

huebl
Copy link
Contributor

@huebl huebl commented Dec 10, 2019

Closes #158

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG have been updated (for bug fixes / features / docs)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@huebl huebl requested a review from atimin December 13, 2019 17:56
@huebl huebl merged commit b398580 into Release4 Dec 13, 2019
@huebl huebl deleted the 158_replace_class_callback_by_function branch December 16, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atimin atimin atimin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huebl @atimin