Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in FilterNode functionality #67

Merged
merged 4 commits into from
Dec 24, 2018
Merged

Conversation

atimin
Copy link
Member

@atimin atimin commented Dec 22, 2018

The following bugs were fixed:

  1. Fix crashing when two operand are referencing on the same value
  2. Fix comparison operator node

@atimin
Copy link
Member Author

atimin commented Dec 22, 2018

Hi, @huebl . My team started using some functionality of EventFilter and fix these bugs.

@atimin
Copy link
Member Author

atimin commented Dec 22, 2018

@huebl , forgot to add some tests. Don't merge it.

@atimin atimin changed the title Fix some errors in FilterNode functionality [WIP]Fix some errors in FilterNode functionality Dec 22, 2018
@atimin atimin requested a review from huebl December 22, 2018 16:12
@atimin atimin added bug Something isn't working wip Work In Pogress labels Dec 22, 2018
@atimin atimin changed the title [WIP]Fix some errors in FilterNode functionality Fix some errors in FilterNode functionality Dec 23, 2018
@atimin atimin removed the wip Work In Pogress label Dec 23, 2018
@atimin
Copy link
Member Author

atimin commented Dec 24, 2018

@huebl , the PR is ready for your review and merging,

@huebl huebl merged commit 1fdd620 into Release3 Dec 24, 2018
@huebl huebl deleted the FixFilterNode branch December 27, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants