Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runing client tests on CI server #68

Merged
merged 12 commits into from
Dec 26, 2018
Merged

Fix runing client tests on CI server #68

merged 12 commits into from
Dec 26, 2018

Conversation

atimin
Copy link
Member

@atimin atimin commented Dec 22, 2018

Closes #45

@atimin atimin added bug Something isn't working wip Work In Pogress labels Dec 22, 2018
@atimin atimin changed the title [WIP]Fix runing client tests on CI server Fix runing client tests on CI server Dec 23, 2018
@atimin atimin removed the bug Something isn't working label Dec 23, 2018
@atimin
Copy link
Member Author

atimin commented Dec 24, 2018

I've embedded the demo server into Ttravis script and it's working well on my machine. But it seems that some tests aren't stable and can't pass in Travis'es environment. @huebl , could you check them?

@atimin atimin added bug Something isn't working and removed wip Work In Pogress labels Dec 24, 2018
@huebl
Copy link
Contributor

huebl commented Dec 24, 2018

Hi @FLIPBack, I look at the problem.

@huebl
Copy link
Contributor

huebl commented Dec 25, 2018

The crashes are very rare in a local environment. Only every 10 to 20 times.

I found an error in the synchronization when closing the connection. After the fix but still more crashes have occurred. My suspicion: Bug #10 still needs to be fixed. The crashes look at least very similar.

@atimin
Copy link
Member Author

atimin commented Dec 26, 2018

Hi, @huebl
I suggest merging this PR into Release 3. Then we reopen #10 and make a new PR to fix it. I advise you to mark your PR or commit with "close(fix) #issue" so that we can see if the bug is fixed in current branch. I tried to find where #10 is closed but didn't manage.

@huebl huebl merged commit 1d54dc9 into Release3 Dec 26, 2018
@huebl huebl deleted the 45-EnableClientTests branch December 27, 2018 18:09
@huebl huebl mentioned this pull request May 19, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants