Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifiers are dropped #36

Closed
slarse opened this issue Mar 1, 2020 · 0 comments · Fixed by #42
Closed

Modifiers are dropped #36

slarse opened this issue Mar 1, 2020 · 0 comments · Fixed by #42
Labels
bug Something isn't working

Comments

@slarse
Copy link
Collaborator

slarse commented Mar 1, 2020

Modifiers should reasonably be part of the content of a node. They're currently just dropped. This means that a node's content isn't limited to a single thing, as was previously assumed. I need to rethink how to handle content and content conflicts.
@slarse slarse added the bug Something isn't working label Mar 1, 2020
slarse added a commit that referenced this issue Mar 3, 2020
@slarse
[fix] Resolve and attach modifiers as "secondary values" #36
d41d50b
This was referenced Mar 3, 2020
Closed
Closed
slarse added a commit that referenced this issue Mar 3, 2020
@slarse
[fix] Deal with merging of modifiers #36
6cdbf47 
But does not deal with conflicts!
@slarse slarse mentioned this issue Mar 3, 2020
Merged
@slarse slarse closed this as completed in #42 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Handle modifiers ASSERT-KTH/spork
1 participant
@slarse