Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content conflicts on non-string values are not handled properly #43

Closed
slarse opened this issue Mar 3, 2020 · 1 comment · Fixed by #68
Closed

Content conflicts on non-string values are not handled properly #43

slarse opened this issue Mar 3, 2020 · 1 comment · Fixed by #68
Labels
bug Something isn't working

Comments

@slarse
Copy link
Collaborator

slarse commented Mar 3, 2020

As of #42 nodes can have both primary and secondary values. Currently, if there is an unresolved conflict in the secondary values, the primary value is flagged as conflicting in the output. For example, the followng merge scenario has an obvious conflict in the visibility modifier:

// base
int x = 2;

// left
private int x = 2;

// right
public int x = 2;

But it will actually be flagged like so:

int
<<<<<<< LEFT
x
=======
x
>>>>>>> RIGHT
= 2;

Which obviously is horrendously incorrect. This needs to be resolved, but it would probably be best to identify some more secondary values first to make sure it's resolved in a generalized fashion.

@slarse slarse added the bug Something isn't working label Mar 3, 2020
slarse added a commit that referenced this issue Mar 8, 2020
This entirely does away with the notion of primary and secondary values, and simply stores all values that are relevant as "equally important"
slarse added a commit that referenced this issue Mar 9, 2020
@slarse
Copy link
Collaborator Author

slarse commented Mar 10, 2020

Secondary values isn't a thing anymore as of #60, but there are still issues with pretty printing conflicts on non-string content values.

@slarse slarse changed the title Content conflicts aren't properly handled when the conflict is on secondary values Content conflicts on non-string values are not handled properly Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant