Zoom and pan: More options in the settings and improved error output #11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lastYoueven
reviewed
Jun 13, 2023
| if ( | ||
| (!isSpecialKey && !usedSingleKeys.has(hotkey)) || | ||
| (isSpecialKey && !usedSpecialKeys.has(hotkey)) | ||
| ) { |
There was a problem hiding this comment.
Yes, I'll fix the code and make it more compact in the coming days, for now it just works.
There was a problem hiding this comment.
Corrected, removed this piece of code and made it smaller and clearer
|
UPD. Slightly changed the approach, now you can push off any extension function of your choice. Removed unnecessary code and changed tooltip class to avoid conflicts in future.
|
AUTOMATIC1111
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to @w-e-w for the suggested improvements in the code.
Improved the error output, now they will accurately identify the problem.
Made Zoom and Adjust brush size optional, as there are certain details.
You can select one of the 3 buttons "Alt", "Shift", "Ctrl" for Zoom and Adjust brush size
Added small tips in the description of the hotkeys, which will help get rid of possible problems
Removed canvas_swap_controls, it is no longer needed
Screenshots/videos:
New Options:
Full settings menu
Accurate error messages
Checklist: