Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the key error exception when processing override_settings keys #13567

Merged

Conversation

LeonZhao28
Copy link
Contributor

Description

There is an option named control_net_detectedmap_dir in the controlnet extension.
If the sd-webui is starting using --nowebui, there maybe no config.json file or no control_net_detectedmap_dir in the config.json.
And when sending a API with control_net_detectedmap_dir key in override_settings, the exception will occur, because the control_net_detectedmap_dir is not in opts.data.
image

The root cause is that the extension registers the options using shared.opts.add_option, in this method, it only updates the attribute data_labels and doesn't update the attribute data.
image

image

Screenshots/videos:

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit eadef35 into AUTOMATIC1111:dev Oct 14, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants