Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launch_utils.py - fixes repetead package reinstalls #14192

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update launch_utils.py - fixes repetead package reinstalls #14192

merged 2 commits into from
Dec 4, 2023

Commits on Dec 4, 2023

  1. Update launch_utils.py to fix wrong dep. checks and reinstalls 

    Fixes failing dependency checks for extensions having a different package name and import name (for example ffmpeg-python / ffmpeg), which currently is causing the unneeded reinstall of packages at runtime.

In fact with current code, the same string is used when installing a package and when checking for its presence, as you can see in the following example:

> launch_utils.run_pip("install ffmpeg-python", "required package")
[ Installing required package: "ffmpeg-python" ... ]
[ Installed ]

> launch_utils.is_installed("ffmpeg-python")
False

... which would actually return true with:

> launch_utils.is_installed("ffmpeg")
True
    @illtellyoulater
    illtellyoulater authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    639ccf2 View commit details
    Browse the repository at this point in the history

  2. Lint

    @missionfloyd
    missionfloyd authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    06725af View commit details
    Browse the repository at this point in the history