Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py #14354

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

ranareehanaslam
Copy link
Contributor

@ranareehanaslam ranareehanaslam commented Dec 18, 2023

Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed

Description

There was a issue in the Script webui.py
when anyone want to run the api only with no webui arguments it was only loading it to the local server only if no listen is passed and either server-name is passed it was being ignored i have fixed It Further Proof of Concept and Screenshot's are attached

testing COMMANDLINE_ARGS
--disable-safe-unpickle --server-name [::] --xformers --opt-sdp-attention --enable-insecure-extension-access --api --opt-channelslast --nowebui --no-gradio-queue --port 7860 --ui-settings-file 'config.json' --ui-config-file 'ui-config.json' --no-download-sd-model

Screenshots/videos:

BEFORE FIX
image
AFTER FIX
image

Checklist:

Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed
@ranareehanaslam
Copy link
Contributor Author

@AUTOMATIC1111 Waiting for your Response sir!

webui.py Outdated Show resolved Hide resolved
@akx
Copy link
Collaborator

akx commented Dec 18, 2023

Please actually read the contributing guidelines.

You're violating at least 2 of the bullet points.

@ranareehanaslam ranareehanaslam changed the title Update webui.py Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py Dec 19, 2023
Co-authored-by: Aarni Koskela <[email protected]>
@ranareehanaslam
Copy link
Contributor Author

Please actually read the contributing guidelines.

You're violating at least 2 of the bullet points.

is it really mean it ..?
am just helping the community

@akx
Copy link
Collaborator

akx commented Dec 19, 2023

is it really mean it ..? am just helping the community

That may be, but you need to abide by the project's rules. The violations I can see are related to the branch you're targeting, and the branch you're making your PR from.

@dhwz
Copy link
Contributor

dhwz commented Dec 19, 2023

Please actually read the contributing guidelines.
You're violating at least 2 of the bullet points.

is it really mean it ..? am just helping the community

I'm sorry but I think you still don't understand what he is talking about.
Any changes for PRs have to be done in the dev branch, you did change the code in master branch and started a PR from there, merging changes from master into dev is NOT allowed, please redo your changes in dev branch and then open a proper NEW PR.

@@ -39,7 +39,7 @@ def api_only():

print(f"Startup time: {startup_timer.summary()}.")
api.launch(
server_name="0.0.0.0" if cmd_opts.listen else "127.0.0.1",
server_name=cmd_opts.server_name or ("0.0.0.0" if cmd_opts.listen else "127.0.0.1"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out on Discord, this should use the initialize_util.gradio_server_name() function that's available in the dev branch.

The dev branch is what this PR should be targeting; a PR targeting master will not get merged.

@missionfloyd missionfloyd changed the base branch from master to dev December 21, 2023 03:46
@AUTOMATIC1111 AUTOMATIC1111 merged commit 83c0758 into AUTOMATIC1111:dev Dec 30, 2023
3 of 4 checks passed
AUTOMATIC1111 added a commit that referenced this pull request Dec 30, 2023
@AUTOMATIC1111
Copy link
Owner

So the actual issue from previous PRs was that the API-only was just ignoring some cmdline args, which does seem like a real problem. I merged this, and applied the change akx suggested.

@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
ruchej pushed a commit to ruchej/stable-diffusion-webui that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants