-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py #14354
Conversation
Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed
@AUTOMATIC1111 Waiting for your Response sir! |
Please actually read the contributing guidelines. You're violating at least 2 of the bullet points. |
Co-authored-by: Aarni Koskela <[email protected]>
is it really mean it ..? |
That may be, but you need to abide by the project's rules. The violations I can see are related to the branch you're targeting, and the branch you're making your PR from. |
I'm sorry but I think you still don't understand what he is talking about. |
@@ -39,7 +39,7 @@ def api_only(): | |||
|
|||
print(f"Startup time: {startup_timer.summary()}.") | |||
api.launch( | |||
server_name="0.0.0.0" if cmd_opts.listen else "127.0.0.1", | |||
server_name=cmd_opts.server_name or ("0.0.0.0" if cmd_opts.listen else "127.0.0.1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pointed out on Discord, this should use the initialize_util.gradio_server_name()
function that's available in the dev
branch.
The dev
branch is what this PR should be targeting; a PR targeting master
will not get merged.
So the actual issue from previous PRs was that the API-only was just ignoring some cmdline args, which does seem like a real problem. I merged this, and applied the change akx suggested. |
Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed
Description
There was a issue in the Script webui.py
when anyone want to run the api only with no webui arguments it was only loading it to the local server only if no listen is passed and either server-name is passed it was being ignored i have fixed It Further Proof of Concept and Screenshot's are attached
testing COMMANDLINE_ARGS
--disable-safe-unpickle --server-name [::] --xformers --opt-sdp-attention --enable-insecure-extension-access --api --opt-channelslast --nowebui --no-gradio-queue --port 7860 --ui-settings-file 'config.json' --ui-config-file 'ui-config.json' --no-download-sd-model
Screenshots/videos:
BEFORE FIX
AFTER FIX
Checklist: