Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent crash due to Script __init__ exception #14407

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 22, 2023

Description

a Script that for some reason fails to initialize can cause a webui to crash

for example a Script like this

from modules import scripts
class Script(scripts.Script):
    def __init__(self):
        assert False, 'This will crash webui'

this issue was brought to my attention by #14404
for whatever reason the this line in of code the extension triggers an uncaught exception and crashes web UI

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 4b6eb80 into dev Dec 30, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the prevent-crash-due-to-Script-__init__-exception branch December 30, 2023 11:54
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants