Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spandrel: "prefer half" instead of "force half" #14500

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

akx
Copy link
Collaborator

@akx akx commented Jan 2, 2024

Description

As discussed with the Spandrel folks, it's good to heed Spandrel's "supports half precision" flag to avoid e.g. black blotches and what-not.

This is why spandrel has the supports_half tag. Transformer models typically don't work well with fp16

  • which issues it fixes, if any
    • None yet, since the current experimental HAT code doesn't set half=True, but if it did, HAT would have a bad time

Screenshots/videos:

None.

Checklist:

As discussed with the Spandrel folks, it's good to heed Spandrel's
"supports half precision" flag to avoid e.g. black blotches and what-not.
@akx akx marked this pull request as ready for review January 2, 2024 08:50
@AUTOMATIC1111 AUTOMATIC1111 merged commit 7c3ab41 into AUTOMATIC1111:dev Jan 2, 2024
3 checks passed
@akx akx deleted the spandrel-prefer-half branch January 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants