[Bug] Fix tab indexes are reseted after restart UI #14637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
light-and-ray
commented
Jan 13, 2024
.gitignore
Outdated
| @@ -38,3 +38,4 @@ notification.mp3 | |||
| /package-lock.json | |||
| /.coverage* | |||
| /test/test_outputs | |||
| .directory | |||
There was a problem hiding this comment.
A file from kde's Dolphin file manager, contains directory's metadata
light-and-ray
changed the title
|
|
light-and-ray
force-pushed
the
fix_tab_indexes_resets_after_restart_ui
branch
from
46fea31
to
56676ff
Compare
|
@AUTOMATIC1111 okay, thanks. Fixed |
AUTOMATIC1111
approved these changes
Jan 20, 2024
4 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you selected in web browser tab
img2img->Resize by, orExtras->Batch Process, then you restart webui, the internal state of tabs' indexes are reseted. It also happened in one my extension, where I used the same pattern of tab_index, it is really annoyingI've found it happens because of
gr.Statecomponent. I've changed it on invisiblegr.Number, and the bug is gone. So I decided to make a PRChecklist: