Add # to the invalid_filename_chars list #14640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply adds the
#character to the invalid_filename_chars list, which causes it to get replaced by_in filenames.Reason is due to a Gradio bug, hashtags in filenames will display as a broken image in the result gallery when the image is saved. This can happen when you have a hashtag in your prompt, lora, etc. if the prompt, lora, or etc. is saved to the filename.
#5271 #5470 (These issues are closed but the problem persists)
Screenshots/videos:
Before change
(sped up a bit)
The image is saved correctly, but can't be displayed.
Filename:
After change
The image is displayed and still saved, expect with
#replaced by_.Filename:
Checklist: