Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix extras big batch crashes #14699

Merged

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Jan 19, 2024

I've found postprocessing in extras tab stably crashes for big batches. It happens because
shared.state.assign_current_image(image_data)
And later:
image_data.close()
Inside postprocessing.py

And also I think it's better to show processed image in preview instead of input image. I decided to fix this crash with using pp.image instead of image_data for preview

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 7c30c5e into AUTOMATIC1111:dev Jan 20, 2024
3 checks passed
@light-and-ray light-and-ray deleted the fix_extras_big_batch_crashes branch January 20, 2024 10:38
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants