Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infotext Lora hashes fro hires fix different lora #16062

Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jun 21, 2024

Description

there exist a minor flaw with infotext Lora hashes

currently the Lora hashes written to the infotext will be the Lora hashes of the "last last activated lores"
normally this works perfectly fine
the issue occurs when the using hires fix
as hires fix allows diffrent prompt which means the user can change the lora
if the uses removs some loras that are in the first pass then the Lora hashes infotext will not have the loras of the first pass obviously


this PR makes changes so it saves the lora hashes in saved in a dict under p.lora_hashes
when on first pass the dict will be set to empty {}
but is_hr_pass it will use the use the existing p.lora_hashes and add any new hashes to the dict

tested with the hires fix button and all seems to work fine

also compacted the code


TI hashes also have similar issues but and more
worse possibly due to where the code is it doesn't even write to infotext consistently
currently I not sure how to fix that, maybe someone who have an idea

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 3bd4a08 into dev Jul 6, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-infotext-Lora-hashes-fro-hires-fix-different-lora branch July 6, 2024 07:04
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants