Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noisy DS_Store files for MacOS #16166

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

richardtallent
Copy link
Contributor

Description

When using this repository locally on MacOS, the OS litters the repository with .DS_Store files, which contain nothing other than custom folder settings, such as view options.

This means that any MacOS user contributing to the repository will need to manually remove these files or at least ensure they don't become part of a commit.

I've added .DS_Store to the .gitignore file, which will resolve this.

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 8, 2024

btw you could set up a git global ignore for your system

@viking1304
Copy link
Contributor

I agree with both of you. I have it in global ignore, but I would prefer to also have it in the local ignore file - not because of me but because of others who do not have a global set.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 8, 2024

clarify I wasn't disagreeing
it's a "by the way" for future reference kind of thing
global ignore .DS_Stor it's probably what every git user on Mac user shoud do

note I don't use Mac

@AUTOMATIC1111 AUTOMATIC1111 merged commit 9f5a98d into AUTOMATIC1111:dev Jul 20, 2024
3 checks passed
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants