Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use empty_like to reduce model loading time #16577

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Oct 22, 2024

use empty_like() instead of zeros_like() in the LoadStateDictOnMeta() we don't have to initialize params with zeros, It will be overwrittened by param.copy_(input_param), (https://github.com/pytorch/pytorch/blob/main/torch/nn/modules/module.py#L2441 )

Checklist:

Copy link
Collaborator

@w-e-w w-e-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with loading process to to vet this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants