-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore the progress from session lost / tab reload #7595
restore the progress from session lost / tab reload #7595
Conversation
@siutin could you please resolve the conflicts so auto will be, in theory, able to review it? |
my problems with it:
|
|
1 - how about saving task id locally in the browser (js localstorage) and using that to restore the session 2 - I'd like to not add any changes to task ids for simplicity and if the side effect of that is that you can load img2img results in text2img tab, that's not a problem 3 - well, how about a button below generate along with other buttons in that row. As an extra together with (1) the button can be made only visible if the task id is stored locally and not visible otherwise, and local task id would be emptied after a generation finishes so the button would normally be hidden. this is getting fairly complex considering user can have multiple tabs open so maybe this extra can be dumped... |
|
e1c91db
to
88624b2
Compare
88624b2
to
70ab21e
Compare
6d9639b
to
3c8a4b7
Compare
dfe3ef4
to
e30aee6
Compare
e30aee6
to
3e5b3c7
Compare
I ended up doing an independent implementation that tracks task id in browser locally and uses that to restore, showing the button only if the task id exists for a task that wasn't finished properly in the client. |
Describe what this pull request is trying to achieve.
This PR attempts to restore the progress bar from session lost / tab reload
Environment this was tested in
Screenshots or videos of your changes
stable-diffusion-webui-restore-progress.mp4